Initial KeyVaultAccessControlClient for Java #12405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OM, README and CHANGELOG files.
…enamed the generated AccessControl client and builder.
…API for getting Role Definitions and some helper classes and resources.
…tion classes and their builders.
vcolin7
added
KeyVault
Client
vcolin7
force-pushed
the
users/vicolina/keyvault-rbac
branch
from
b0635bc to
0b1fd31
Compare
vcolin7
requested review from
danieljurek,
JimSuplizio,
mitchdenny,
samvaity and
weshaggard
as code owners
JimSuplizio
approved these changes
Jun 25, 2020
christothes
reviewed
Jun 25, 2020
...on/src/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlClient.java
Outdated
Show resolved
Hide resolved
…t KeyVaultRoleAssignmentProperties.
…ntrolAsyncClient get error messages for parameter validation.
…from public API signatures. Added convenience layer models to be exposed as public API.
heaths
approved these changes
Sep 1, 2020
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
...tion/src/main/java/com/azure/security/keyvault/administration/models/KeyVaultPermission.java
Show resolved
Hide resolved
| * @param principalId The principal ID assigned to the role. This maps to the ID inside the Active Directory. | ||
| * It can point to a user, service principal, or security group. | ||
| */ | ||
| public KeyVaultRoleAssignmentProperties(String roleDefinitionId, String principalId) { |
There was a problem hiding this comment.
These are required parameters for create methods. Are they being passed to those methods directly as well?
There was a problem hiding this comment.
These parameters are passed directly to the service methods.
This Properties object is based on how the service Swagger groups parameters, however, I believe we certainly could change the method signature to take all required values like this:
public Mono<KeyVaultRoleAssignment> createRoleAssignment(
KeyVaultRoleAssignmentScope roleScope,
String roleDefinitionId,
String principalId)Instead of what we have today:
public Mono<KeyVaultRoleAssignment> createRoleAssignment(
KeyVaultRoleAssignmentScope scope,
KeyVaultRoleAssignmentProperties properties)What do you think @heaths?
There was a problem hiding this comment.
I thought we were doing it that way in .NET after a discussion, but I don't see that in source. @christothes and @sadasant, was it a different method we were talking about pulling roleDefinitionId and principalId out of, or was that for the model constructor? I may just be remembering wrong here.
There was a problem hiding this comment.
I think we still use a properties bag in .NET, but I like the individual parameter shape better.
…ic APIs. Corrected version number in files inside /eng.
g2vinay
reviewed
Sep 3, 2020
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/security/keyvault/administration/KeyVaultAccessControlAsyncClient.java
Outdated
Show resolved
Hide resolved
weshaggard
reviewed
Sep 3, 2020
vcolin7
force-pushed
the
users/vicolina/keyvault-rbac
branch
from
9ed0f6f to
5a208bf
Compare
vcolin7
force-pushed
the
users/vicolina/keyvault-rbac
branch
from
8ede798 to
ca96cc7
Compare
vcolin7
force-pushed
the
users/vicolina/keyvault-rbac
branch
from
ca96cc7 to
a476010
Compare
…WithResponse()`. Made fixes for tests cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and samples are still pending and the README is a work in progress.
Based on issue: #8007.